Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Conversation

@oyri
Copy link
Contributor

@oyri oyri commented Feb 1, 2022

To enable to use previous version av Trivy when breaking changes occur before container-scan action is updated.
If not set, default is latest version.

@ghost
Copy link

ghost commented Feb 1, 2022

CLA assistant check
All CLA requirements met.

Copy link

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 🎉

@Viktork25
Copy link

Can I suggest that trying to use a different version we will need to do changes also in the way that trivy scans the image?Because in the latest version 0.23 of trivy, the trivy run with the following structure trivy image [command options] image_name and on old version runs like this trivy [image-name]

@oyri
Copy link
Contributor Author

oyri commented Feb 2, 2022

Can I suggest that trying to use a different version we will need to do changes also in the way that trivy scans the image?Because in the latest version 0.23 of trivy, the trivy run with the following structure trivy image [command options] image_name and on old version runs like this trivy [image-name]

I didn't add this since it's already fixed in a different pull request, so I didn't want to cause unessasary merge conflicts... Is it not better to include pull request #123 first before mine?

Copy link

@scottwestover scottwestover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR!
For the new input, it might be worth adding to the readme here: https://github.com/Azure/container-scan#action-inputs

@oyri
Copy link
Contributor Author

oyri commented Feb 3, 2022

Thanks for opening the PR! For the new input, it might be worth adding to the readme here: https://github.com/Azure/container-scan#action-inputs

I thought the release-branch was the correct to merge to and this one does not have a readme with this info, so maybe I should rather merge to master and then update the readme as well. Good point to update the readme.

If master is correct to use, I think I have to create a new pull request with these changes in it.

Sorry about this, but now there is a new pull request to master which includes these changes and update to README: #130.

If that is more correct, I will delete this pull request.

@oyri oyri changed the base branch from releases/v0 to master February 3, 2022 06:43
@oyri oyri changed the base branch from master to releases/v0 February 3, 2022 06:43
@github-actions
Copy link

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Feb 17, 2022
@oyri
Copy link
Contributor Author

oyri commented Mar 8, 2022

Replaced by #130, close this one.

@oyri oyri closed this Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

idle Inactive for 14 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants