-
Notifications
You must be signed in to change notification settings - Fork 40
Specify Trivy version in workflow file #125
Conversation
ckotzbauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR 🎉
|
Can I suggest that trying to use a different version we will need to do changes also in the way that trivy scans the image?Because in the latest version 0.23 of trivy, the trivy run with the following structure |
I didn't add this since it's already fixed in a different pull request, so I didn't want to cause unessasary merge conflicts... Is it not better to include pull request #123 first before mine? |
scottwestover
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR!
For the new input, it might be worth adding to the readme here: https://github.com/Azure/container-scan#action-inputs
I thought the release-branch was the correct to merge to and this one does not have a readme with this info, so maybe I should rather merge to master and then update the readme as well. Good point to update the readme. If master is correct to use, I think I have to create a new pull request with these changes in it. Sorry about this, but now there is a new pull request to master which includes these changes and update to README: #130. If that is more correct, I will delete this pull request. |
|
This PR is idle because it has been open for 14 days with no activity. |
|
Replaced by #130, close this one. |
To enable to use previous version av Trivy when breaking changes occur before container-scan action is updated.
If not set, default is latest version.