Skip to content

Conversation

@eikooc
Copy link

@eikooc eikooc commented Nov 30, 2023

As Github Actions are deprecating Node v16, update to use v20.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

#63

As Github Actions are deprecating
node v16, update to use v20
@eikooc
Copy link
Author

eikooc commented Nov 30, 2023

@microsoft-github-policy-service agree

@meenakshi-koushik
Copy link

As outlined in the blog post, the workflows are already emitting deprecation warnings. It would be great if this update can be merged.

@bamancio-futura
Copy link

waiting for this

@SeptBlast
Copy link

@bamancio-futura you can use this Action plugin to to handle the node20 fixes

https://github.com/marketplace/actions/container-registry-login

@YvesEarnix
Copy link

Look on the Docker login action created by docker

name: ci

on:
  push:
    branches: main

jobs:
  login:
    runs-on: ubuntu-latest
    steps:
      -
        name: Login to ACR
        uses: docker/login-action@v3
        with:
          registry: <registry-name>.azurecr.io
          username: ${{ secrets.AZURE_CLIENT_ID }}
          password: ${{ secrets.AZURE_CLIENT_SECRET }}

@mialliedo
Copy link

Waiting for this :)

@lgmorand lgmorand merged commit f3bf641 into Azure:master May 21, 2024
@lgmorand
Copy link
Collaborator

I was waiting too. Had to complain. Now it's done

@meenakshi-koushik
Copy link

Amazing work, everyone! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants