Conversation
bachuv
approved these changes
Dec 16, 2023
Collaborator
bachuv
left a comment
There was a problem hiding this comment.
Thanks for making this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating microsoft/durabletask-mssql#198, I noticed that some of the new distributed tracing code casts history events based on certain assumptions, which aren't always true in production. The issue can result in a poison message with the following error:
This PR replaces the cast operation with a type-safe check, removing the possibility of
InvalidCastException.Note that the root cause of the bug observed by the user is probably specific to the MSSQL backend: it might not be deserializing history events correctly, resulting in unexpected Event ID matches. Regardless, I felt it made sense to make a fix here for defense in depth.