support task registration from interface with inheritance, generics, method overloading#1021
Merged
cgillum merged 4 commits intoAzure:mainfrom Jan 12, 2024
Merged
Conversation
|
@davidmrdavid adding you for review. This is for updating interface methods registration as task-activity for objects implementing interfaces with generic type. |
cgillum
reviewed
Jan 9, 2024
cgillum
reviewed
Jan 10, 2024
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Overall, the change seems good. I think there's just a few things I'd like to have clarified via additional comments in the code.
Member
|
/azp run |
|
EDIT: Azure Pipelines run scheduled successfully. |
Collaborator
|
/azp run |
|
EDIT: Azure Pipelines run scheduled successfully. |
cgillum
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a bug in
TaskHubWorker.AddTaskActivitiesFromInterfacewhere each method of a registered interface is keyed by a weak "qualified name" that hits collisions when using C# code reuse features such as inheritance, generics, method overloading.This is reproducible even with
useFullyQualifiedMethodNames = true.This PR fixes by making a stronger qualified name in "V2" methods for task registration and client creation.
It is essential to keep the "V1" methods for back-compatibility.