Update RemoteOrchestrationServiceClient.cs#1032
Merged
shankarsama merged 1 commit intoAzure:mainfrom Feb 12, 2024
Merged
Conversation
"Refactored Exception Handling in Retry Logic for RemoteOrchestrationServiceClient The DurableTask.AzureServiceFabric NuGet package was previously using HttpWebRequest (.NET 4) and has since been updated to use HttpClient. However, the associated exception handling in the retry logic was not updated accordingly. Originally, the catch block was designed to handle WebException, a legacy exception type associated with HttpWebRequest. HttpClient, however, throws HttpRequestException for request-related issues, not WebException. This oversight led to the retry logic failing to function as intended, as it was not catching the correct exception type. This is particularly critical for the RemoteOrchestrationServiceClient, which relies on this retry mechanism to detect changes in the SF partition leader. This commit updates the catch block to handle HttpRequestException, aligning with the HttpClient usage and restoring the intended functionality of the retry logic."
shankarsama
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Refactored Exception Handling in Retry Logic for RemoteOrchestrationServiceClient
The DurableTask.AzureServiceFabric NuGet package was previously using HttpWebRequest (.NET 4) and has since been updated to use HttpClient. However, the associated exception handling in the retry logic was not updated accordingly.
Originally, the catch block was designed to handle WebException, a legacy exception type associated with HttpWebRequest. HttpClient, however, throws HttpRequestException for request-related issues, not WebException.
This oversight led to the retry logic failing to function as intended, as it was not catching the correct exception type. This is particularly critical for the RemoteOrchestrationServiceClient, which relies on this retry mechanism to detect changes in the SF partition leader.
This commit updates the catch block to handle HttpRequestException, aligning with the HttpClient usage and restoring the intended functionality of the retry logic."