Increase DTFx.Core and DTFx.AS versions#1053
Merged
davidmrdavid merged 2 commits intomainfrom Mar 18, 2024
Merged
Conversation
cgillum
reviewed
Mar 18, 2024
| <MajorVersion>1</MajorVersion> | ||
| <MinorVersion>17</MinorVersion> | ||
| <PatchVersion>1</PatchVersion> | ||
| <PatchVersion>2</PatchVersion> |
Member
There was a problem hiding this comment.
I recommend we exclude this change from the release since 1) it appears we didn't make any changes to DurableTask.AzureStorage and 2) the change to DurableTask.Core doesn't apply to DurableTask.AzureStorage (AFAICT, the entity-specific error handling only applies to backends like MSSQL that don't yet implement out-of-proc entity support).
Collaborator
Author
There was a problem hiding this comment.
yeah I felt similarly that this was a rather light release so it makes sense not to release DTFx.AS at all. Incorporated your feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in title, routine PR for upcoming release