Add TaskContext null check in AsyncTaskActivity error handling#1055
Merged
cgillum merged 2 commits intoAzure:mainfrom Mar 21, 2024
Merged
Add TaskContext null check in AsyncTaskActivity error handling#1055cgillum merged 2 commits intoAzure:mainfrom
cgillum merged 2 commits intoAzure:mainfrom
Conversation
added 2 commits
March 20, 2024 14:59
…ask activity error handling
Member
|
/azp run |
|
EDIT: Azure Pipelines run started successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a null check during error handling in
AsyncTaskActivity. As described in #1054, if thecontextparameter is passed as null toRunAsync, and the call toExecuteAsyncfails for some task-specific reason, the error handling code uses that parameter to check which error propagation mode is being used. If the parameter is null, an unexpectedNullReferenceExceptionwill be raised, instead of the expectedTaskFailureException.A null check is added to prevent this from happening.