Change CreateTaskOrchestrationAsync tp throw OrchestrationAlreadyExistsException#1060
Merged
Change CreateTaskOrchestrationAsync tp throw OrchestrationAlreadyExistsException#1060
Conversation
…to throw Orchestration
Member
Author
|
Looks like the failing CI is new and not part of our normal CIs. I think we can safely ignore its results. |
Collaborator
|
@cgillum: agreed. Surprised to see it running automatically on every PR, but that's fine since it's just tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to allow exception handling code to catch a more specific exception and differentiate between unexpected errors and expected errors.
This is largely non-breaking because
OrchestrationAlreadyExistsExceptionalready derives fromInvalidOperationException.Note that the
IOrchestrationServiceClientinterface already documents that theCreateTaskOrchestrationAsyncmethods should be throwingOrchestrationAlreadyExistsException, so this change fixes the AzureStorageOrchestrationService's implementation to follow the existing spec.