New APIs and updates related to failure details propagation#1067
Merged
New APIs and updates related to failure details propagation#1067
Conversation
davidmrdavid
approved these changes
Apr 18, 2024
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
Approved w/ suggestions
davidmrdavid
approved these changes
Apr 23, 2024
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
approved once CI goes green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards properly fixing Azure/azure-functions-durable-extension#2476.
This PR fixes a couple things:
IsCausedBy<T>()API doesn't correctly handle exceptions defined outside of mscorlib. This PR fixes that.I also went ahead and bumped the minor version number of DurableTask.Core since these changes impact the public API surface area.