Add Versioning support in durabletask(phase1)#1071
Merged
cgillum merged 4 commits intoAzure:mainfrom Apr 25, 2024
skyao:versioning-phase1
Merged
Add Versioning support in durabletask(phase1)#1071cgillum merged 4 commits intoAzure:mainfrom skyao:versioning-phase1
cgillum merged 4 commits intoAzure:mainfrom
skyao:versioning-phase1
Conversation
… current orchestration instance Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
…trationInstance so that it can be used in the orchestration code Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
This was referenced Apr 22, 2024
cgillum
reviewed
Apr 22, 2024
…ion on OrchestrationContext Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
jviau
approved these changes
Apr 23, 2024
Collaborator
jviau
left a comment
jviau
left a comment
There was a problem hiding this comment.
This is great! Getting version was annoying before - I always had to extract it in the middleware and save it somewhere (typically a property on the orchestration)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code updates:
OrchestrationContext
Add a new field called Version to indicate the version of the current orchestration instance. Version will be set when the orchestration instance is created.
TaskOrchestrationExecutor
Get the instance version from version field on the ExecutionStartedEvent and save it to TaskOrchestrationContext.Version so that it can be used in the orchestration code.