Update Main Branch Changes with Azure Storage Track2 Methods#1081
Merged
nytian merged 1 commit intonytian/updateasv12from May 7, 2024
Merged
Update Main Branch Changes with Azure Storage Track2 Methods#1081nytian merged 1 commit intonytian/updateasv12from
nytian merged 1 commit intonytian/updateasv12from
Conversation
nytian
commented
May 1, 2024
| TableQuery.GenerateFilterCondition("PartitionKey", QueryComparisons.LessThan, "@"), | ||
| TableOperators.Or, | ||
| TableQuery.GenerateFilterCondition("PartitionKey", QueryComparisons.GreaterThanOrEqual, "A"))); | ||
| conditions.Add($"{nameof(OrchestrationInstanceStatus.PartitionKey)} lt '@' or {nameof(OrchestrationInstanceStatus.PartitionKey)} ge 'A'"); |
Collaborator
Author
There was a problem hiding this comment.
In Azure Storage Track2, we don't have TableQuery anymore, so I translate the original query with this to align with other context.
Collaborator
There was a problem hiding this comment.
can you please add a comment on top of this method that documents the query? It's a big hard to follow as-is
Collaborator
Author
There was a problem hiding this comment.
Just want to confirm you mean what $"{nameof(OrchestrationInstanceStatus.PartitionKey)} lt '@' or {nameof(OrchestrationInstanceStatus.PartitionKey)} ge 'A'") means, right?
nytian
commented
May 1, 2024
nytian
commented
May 1, 2024
davidmrdavid
reviewed
May 3, 2024
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
Left a few comments, but mostly looks good!
davidmrdavid
approved these changes
May 3, 2024
This was referenced May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
nytian/updateasv12: Syncs updates between the main branch and azure-storage-v12.Branch
nytian/merge_main(feature branch): Built on branchnytian/updateasv12, this PR includes adjustments necessary for the integration of previous updates into Azure Storage Track2.After this PR is approved and merged, then I will merge branch
nytian/updateasv12toazure-storage-v12.