Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
||
| on: | ||
| push: | ||
| branches: [ "main", "dajusto/code-ql", "*" ] # TODO: remove development branch after approval |
There was a problem hiding this comment.
@davidmrdavid do the development branches still need to be removed?
There was a problem hiding this comment.
Yes, I'll remove this in a follow up PR, totally blanked out, my mistake
CodeQL (Code Query Language?) is a service that checks against CVEs and other compliance requirements using static analysis in our repos. It needs to be executed weekly.
Our 1ES pipeline already has this, but we need to make it run weekly, so our 1ES pipeline now has a weekly schedule.
We also need to add it directly on GitHub, which is done through the
codeQL.ymlGitHub workflow.In addition, our open telemetry sample was throwing a warning because there was an
asyncmethod nor await'ing anything. I've made the method synchronous to make the warning go away. See: 8d2223a