Fix exception when Continue-as-New and Termination happens at the same time#888
Merged
davidmrdavid merged 1 commit intoAzure:dajusto/patch-continue-as-new-and-terminate-racefrom May 5, 2023
Conversation
davidmrdavid
changed the base branch from
main
to
dajusto/patch-continue-as-new-and-terminate-race
davidmrdavid
approved these changes
May 5, 2023
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
Thank you so much for your contribution. This looks good to me, although we'll need to do a bit more testing before merging it to main proper. I've changed the target branch to a feature branch that we'll use for testing. Thanks!
davidmrdavid
merged commit 10b0194
into
Azure:dajusto/patch-continue-as-new-and-terminate-race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop Continue-as-New when runtime state already in terminated status
Related issue: Azure/azure-functions-durable-extension#2264