Skip to content

remove orchestration tags from entity action #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastianburckhardt merged 1 commit into from
Sep 8, 2023
Merged

remove orchestration tags from entity action #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/DurableTask.Core/Entities/OperationFormat/StartNewOrchestrationOperationAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,5 @@ public class StartNewOrchestrationOperationAction : OperationAction
/// The input of the sub-orchestration.
/// </summary>
public string? Input { get; set; }

/// <summary>
/// Tags to be applied to the sub-orchestration.
/// </summary>
public IDictionary<string, string>? Tags { get; set; }
}
}
4 changes: 3 additions & 1 deletion src/DurableTask.Core/TaskEntityDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,9 @@ void ProcessSendStartMessage(WorkItemEffects effects, OrchestrationRuntimeState
};
var executionStartedEvent = new ExecutionStartedEvent(-1, action.Input)
{
Tags = OrchestrationTags.MergeTags(action.Tags, runtimeState.Tags),
Tags = OrchestrationTags.MergeTags(
runtimeState.Tags,
new Dictionary<string, string>() { { OrchestrationTags.FireAndForget, "" } }),
OrchestrationInstance = destination,
ParentInstance = new ParentInstance
{
Expand Down