Conversation
Collaborator
Author
|
Please ignore the servicebus pipeline. That's the pipeline I added for df v3 tests. I canceled that one and then it becomes failure :( |
bachuv
reviewed
Oct 13, 2023
cgillum
approved these changes
Oct 14, 2023
Member
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
The change looks good to me. As Varshi already mentioned, let's validate using the Functions V1 smoke test before merging.
Collaborator
Author
|
Tested with smoketestsv1 and it works at my end. |
nytian
added a commit
that referenced
this pull request
Oct 25, 2023
* remove STJ with Newtonsoft * increase DTFx.AS version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The System.Text.Json package refers to Systems.Buffer which is not supported in DurableFunctions V1 host. Replace this package with Newtonsoft.