-
Notifications
You must be signed in to change notification settings - Fork 38
feat: add headers for tenantID and clientRequestID #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
britaniar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| serverAddress string, | ||
| httpClient *http.Client, | ||
| ) (*AttributeBasedVMSizeRecommenderClient, error) { | ||
| tenantID := os.Getenv(tenantIDEnvVarName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, who set this env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The env var will be set in the fleet-hub-agent chart.
Description of your changes
Set headers for
tenantIDandclientRequestIDin attributeBasedVMSizeRecommender clientFixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Tested in standalone with a test client: 88caa9
fleet-hub-agent deployment is updated with environment vars:
VMSize recommendation is successfully generated:
clientRequestID is properly passed to compute-svc too:
Special notes for your reviewer