feat: add ready to join condition to MC #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
circy9
reviewed
Jul 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage ? 63.08%
=======================================
Files ? 10
Lines ? 921
Branches ? 0
=======================================
Hits ? 581
Misses ? 311
Partials ? 29
Continue to review full report at Codecov.
|
circy9
reviewed
Jul 21, 2022
circy9
requested changes
Jul 21, 2022
Contributor
circy9
left a comment
circy9
left a comment
There was a problem hiding this comment.
Please fix the last minor comment
circy9
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add a ready-to-join condition in memberCluster to avoid the race condition of the member agent giving up after getting denied access to the hub cluster resources.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Integration test
Special notes for your reviewer