feat: add the pending condition and status #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fei-Guo
reviewed
Aug 23, 2022
| case errors.Is(applyErr, ErrStillPendingManifest): | ||
| if appliedCond == nil || appliedCond.Status != metav1.ConditionUnknown { | ||
| klog.V(2).InfoS("Some selected resources are still waiting to be applied", "placement", placementRef) | ||
| r.Recorder.Event(placement, corev1.EventTypeWarning, "ResourceApplyPending", "Some selected resources are still waiting to be applied to the member cluster") |
Contributor
There was a problem hiding this comment.
Is this necessary to send event for pending status?
Contributor
Author
There was a problem hiding this comment.
how about appliedCond.Status == metav1.ConditionTrue? Which means it was applied but somehow now pending?
Contributor
There was a problem hiding this comment.
how about appliedCond.Status == metav1.ConditionTrue? Which means it was applied but somehow now pending?
That is ok. You may also need to rephrase the event msg to indicate something unusual happened.
Fei-Guo
approved these changes
Aug 23, 2022
weng271190436
pushed a commit
to weng271190436/fleet
that referenced
this pull request
Nov 3, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
IT
Special notes for your reviewer
This is to fix #239