Skip to content

revert: revert leader election change #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aagusuab merged 1 commit into from
Aug 29, 2022
Merged

revert: revert leader election change #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ install-hub-agent-helm:
--set image.pullPolicy=Never \
--set image.repository=$(REGISTRY)/$(HUB_AGENT_IMAGE_NAME) \
--set image.tag=$(HUB_AGENT_IMAGE_VERSION) \
--set logVerbosity=5
--set logVerbosity=5 \
--set namespace=fleet-system

.PHONY: e2e-hub-kubeconfig-secret
e2e-hub-kubeconfig-secret:
Expand All @@ -162,7 +163,8 @@ install-member-agent-helm: install-hub-agent-helm e2e-hub-kubeconfig-secret
--set refreshtoken.tag=$(REFRESH_TOKEN_IMAGE_VERSION) \
--set image.pullPolicy=Never --set refreshtoken.pullPolicy=Never \
--set config.memberClusterName="kind-$(MEMBER_KIND_CLUSTER_NAME)" \
--set logVerbosity=5
--set logVerbosity=5 \
--set namespace=fleet-system
# to make sure member-agent reads the token file.
kubectl delete pod --all -n fleet-system

Expand Down
1 change: 0 additions & 1 deletion cmd/memberagent/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ func main() {
LeaderElection: *enableLeaderElection,
LeaderElectionNamespace: *leaderElectionNamespace,
LeaderElectionID: "3111024923.hub.fleet.azure.com",
LeaderElectionConfig: memberConfig,
Namespace: mcNamespace,
}

Expand Down
5 changes: 5 additions & 0 deletions test/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,9 @@ kubectl --context=kind-hub-testing -n fleet-system get pod
4. Check the logs of the member cluster controller
```shell
kubectl --context=kind-member-testing -n fleet-system get pod
```

5. uninstall the resources
```shell
make uninstall-helm
```