feat: Update MC & IMC API comments #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
circy9
changed the title
Fei-Guo
reviewed
Sep 6, 2022
Fei-Guo
reviewed
Sep 6, 2022
ryanzhang-oss
approved these changes
Sep 6, 2022
5 tasks
Arvindthiru
pushed a commit
to Arvindthiru/fleet-public
that referenced
this pull request
Oct 17, 2025
* Added support for new properties Signed-off-by: michaelawyu <chenyu1@microsoft.com> * Minor fixes Signed-off-by: michaelawyu <chenyu1@microsoft.com> * Minor fixes Signed-off-by: michaelawyu <chenyu1@microsoft.com> --------- Signed-off-by: michaelawyu <chenyu1@microsoft.com> Co-authored-by: Ryan Zhang <yangzhangrice@hotmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
❯ k get membercluster
NAME JOINED AGE
aks-member-10 5d
aks-member-11 4d23h
❯ k get membercluster aks-member-4 -o=custom-columns='NAME:.metadata.name,JOINED:.status.conditions[?(@.type=="ConditionTypeMemberClusterJoin")].status'
NAME JOINED
aks-member-4
❯ k get membercluster aks-member-4 -o=custom-columns='NAME:.metadata.name,JOINED:.status.conditions[?(@.type=="Joined")].status'
NAME JOINED
aks-member-4 True
Fixes #256
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make e2e-tests