feat: block the reserved namespaces for placement #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fei-Guo
approved these changes
Sep 7, 2022
circy9
reviewed
Sep 8, 2022
|
|
||
| // if SkippedNamespaces is set, skip any events related to the object in these namespaces. | ||
| if _, ok := d.SkippedNamespaces[cwKey.Namespace]; ok { | ||
| if !utils.ShouldPropagateNamespace(cwKey.Namespace, d.SkippedNamespaces) { |
Contributor
There was a problem hiding this comment.
Shall we also check IsResourceDisabled in this function as well?
Contributor
There was a problem hiding this comment.
Also, shall we block more networking resources types in pkg/utils/apiresources.go?
Contributor
Author
There was a problem hiding this comment.
IsResourceDisabled is checked in the utils.ShouldPropagateResource
Arvindthiru
pushed a commit
to Arvindthiru/fleet-public
that referenced
this pull request
Oct 17, 2025
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.5.0 to 3.6.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@184bdaa...5e57cd1) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: 3.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan Zhang <yangzhangrice@hotmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes:
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
IT
Special notes for your reviewer