Skip to content

Conversation

@circy9
Copy link
Contributor

@circy9 circy9 commented Sep 7, 2022

Description of your changes

  • min and max validation of heartbeatPeriodSeconds doesn't exist in CRD due to typos in kubebuilder annotatinos

Fixes #267

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

make test

@ryanzhang-oss ryanzhang-oss changed the title bug: Fix kubebuilder annotations fix: Fix kubebuilder annotations Sep 7, 2022
@circy9 circy9 merged commit b7abcfb into main Sep 7, 2022
@zhiying-lin zhiying-lin deleted the liqian/fixapi branch August 16, 2023 08:40
Arvindthiru added a commit to Arvindthiru/fleet-public that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] min and max of heartbeatPeriodSeconds is missing from MC CRD

3 participants