Skip to content

fix: Remove all nodePorts in the propagated service manifests #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanzhang-oss merged 2 commits into from
Sep 14, 2022
Merged

fix: Remove all nodePorts in the propagated service manifests #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc05577
fix: Remove all nodePorts in the propagated service manifests
Fei-Guo Sep 14, 2022
3fc47f0
Merge branch 'main' into fguo-dev2
ryanzhang-oss Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/controllers/clusterresourceplacement/resource_selector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,22 @@ func generateManifest(object *unstructured.Unstructured) (*workv1alpha1.Manifest
unstructured.RemoveNestedField(object.Object, "spec", "clusterIP")
unstructured.RemoveNestedField(object.Object, "spec", "clusterIPs")
}
// We should remove all node ports that are assigned by hubcluster if any.
unstructured.RemoveNestedField(object.Object, "spec", "healthCheckNodePort")

vals, found, err := unstructured.NestedFieldNoCopy(object.Object, "spec", "ports")
if found && err == nil {
if ports, ok := vals.([]interface{}); ok {
for i := range ports {
if each, ok := ports[i].(map[string]interface{}); ok {
delete(each, "nodePort")
}
}
}
}
if err != nil {
return nil, errors.Wrapf(err, "failed to get the ports field in Serivce object, name =%s", object.GetName())
}
}

rawContent, err := object.MarshalJSON()
Expand Down