test: Connecting Work-api to fleet join/leave #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
approved these changes
Sep 16, 2022
zhiying-lin
reviewed
Sep 16, 2022
| resourceNamespace = testutils.NewNamespace(resourceNamespaceName) | ||
| testutils.CreateNamespace(*MemberCluster, resourceNamespace) | ||
|
|
||
| // Member Cluster must join the fleet for Work API to work. |
Contributor
There was a problem hiding this comment.
discussed with @ryanzhang-oss.
Let's make sure join member cluster in BeforeSuite and delete it in AfterSuite.
As the result, please remove join_leave_member_test.go as join/leave has been covered in the Before/After Suite.
cc @Arvindthiru
1 task
weng271190436
pushed a commit
to weng271190436/fleet
that referenced
this pull request
Nov 3, 2025
Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
1 task
weng271190436
pushed a commit
to weng271190436/fleet
that referenced
this pull request
Nov 7, 2025
This reverts commit 4161bca. Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer