test: Move join/leave to Before/After Suites #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
changed the title
github-actions
bot
added
title-needs-formatting
and removed
title-needs-formatting
labels
Arvindthiru
force-pushed
the
RefactorJoinLeaveE2E
branch
from
9807594 to
a81aeab
Compare
Contributor
Author
|
Had to create a new suite for a test @ryanzhang-oss added which involves placement API before joining and after joining |
Contributor
Author
|
Only made changes/removed helper files used by join/leave workflow, other helper methods will be refactored in #286 |
zhiying-lin
reviewed
Sep 21, 2022
zhiying-lin
reviewed
Sep 22, 2022
Arvindthiru
force-pushed
the
RefactorJoinLeaveE2E
branch
from
2a277ea to
4440a10
Compare
ryanzhang-oss
approved these changes
Sep 22, 2022
zhiying-lin
reviewed
Sep 23, 2022
Comment on lines
+107
to
+124
| Expect(HubCluster.KubeClient.Get(ctx, types.NamespacedName{Name: mc.Name}, mc)).Should(Succeed(), "Failed to retrieve member cluster %s in %s cluster", mc.Name, HubCluster.ClusterName) | ||
| mc.Spec.State = v1alpha1.ClusterStateJoin | ||
| Expect(HubCluster.KubeClient.Update(ctx, mc)).Should(Succeed(), "Failed to update member cluster %s in %s cluster", mc.Name, HubCluster.ClusterName) | ||
|
|
||
| By("check if member cluster condition is updated to Joined") | ||
| wantMCStatus = v1alpha1.MemberClusterStatus{ | ||
| AgentStatus: imcJoinedAgentStatus, | ||
| Conditions: mcJoinedConditions, | ||
| } | ||
| Eventually(func() error { | ||
| if err := HubCluster.KubeClient.Get(ctx, types.NamespacedName{Name: mc.Name}, mc); err != nil { | ||
| return err | ||
| } | ||
| if statusDiff := cmp.Diff(wantMCStatus, mc.Status, mcStatusCmpOptions...); statusDiff != "" { | ||
| return fmt.Errorf("member cluster(%s) status mismatch (-want +got):\n%s", mc.Name, statusDiff) | ||
| } | ||
| return nil | ||
| }, testutils.PollTimeout, testutils.PollInterval).Should(Succeed(), "Failed to wait for member cluster %s to have status %s", mc.Name, wantMCStatus) |
Contributor
There was a problem hiding this comment.
we could refactor it as the util, cause it's more like a setup. The whole test is to focus on validating the placement behavior.
1 task
weng271190436
added a commit
to weng271190436/fleet
that referenced
this pull request
Nov 3, 2025
* remove CRP and MC validation Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * remove v1alpha1 work Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * change Makefile Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * return error if v1alpha1 API is enabled Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * apply suggestion Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> --------- Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> Co-authored-by: Wei Weng <Wei.Weng@microsoft.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer