Skip to content

Conversation

@ryanzhang-oss
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss commented Sep 21, 2022

Description of your changes

  1. move the work-api controllers to fleet repo
    • we keep the API definition in the azure repo
    • we still use the upstream API so the group is "multicluster.x-k8s.io"
  2. fix lint errors that work-api repo ci didn't catch
  3. fix test errors newly discovered in the move
  4. fix test complain that the join flag is a race

I am working with the work-api community to upstream our API to the sig repo. If we managed to do so then I can archive the azure work-api repo and use the upstream for API reference.

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

existing test

Special notes for your reviewer

all the changes are either copy-pasted or to fix compile or lint errors.

@ryanzhang-oss ryanzhang-oss marked this pull request as draft September 21, 2022 21:49
@ryanzhang-oss ryanzhang-oss marked this pull request as ready for review September 21, 2022 23:04
@Fei-Guo Fei-Guo merged commit 08e7660 into Azure:main Sep 22, 2022
@ryanzhang-oss
Copy link
Contributor Author

#281

weng271190436 added a commit to weng271190436/fleet that referenced this pull request Nov 3, 2025
@weng271190436 weng271190436 mentioned this pull request Nov 3, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants