fix: Resolved flaky RefresherCancelContext test #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ealianis
changed the title
Ealianis
changed the title
Ealianis
changed the title
added 2 commits
October 28, 2022 13:38
ryanzhang-oss
approved these changes
Oct 28, 2022
weng271190436
pushed a commit
to weng271190436/fleet
that referenced
this pull request
Dec 1, 2025
* add k8version and CAData to the clusterProfile Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com> * resolve go.mod Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com> * fix UT Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com> * fix the UT and e2e Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com> * fix the race Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com> --------- Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Increase the timeout duration to account for a hanging thread. Verified the return of the refresh token.
Fixes #204
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Test pass locally.