Skip to content

Conversation

@Arvindthiru
Copy link
Contributor

@Arvindthiru Arvindthiru commented Oct 19, 2022

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@Arvindthiru Arvindthiru marked this pull request as ready for review October 24, 2022 18:18
Copy link
Contributor

@ryanzhang-oss ryanzhang-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. The test is very readable. I think we should add a case that only part of the manifests in the work applied successfully.

@Arvindthiru Arvindthiru merged commit 18c5a77 into Azure:main Oct 24, 2022
weng271190436 added a commit to weng271190436/fleet that referenced this pull request Dec 1, 2025
remove dangling v1alpha1 helm reference

Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Co-authored-by: Wei Weng <Wei.Weng@microsoft.com>
@weng271190436 weng271190436 mentioned this pull request Dec 1, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants