-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Added ownerRef to agent created webhook config. #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Arvindthiru , as discussed there are multiple solutions to the problem noted in issue #345. For the draft I went with the least impactful as the owner reference approach seems the most intuitive. However, binding to the namespace feels odd. Ideally we would bind to the webhook service itself. Unfortunately due to the limitations of owner references we cannot, as the The other option could be a cleanup binary. But that may be overkill. Thoughts? |
Binding the fleet-system namespace as the owner for ValidatingWebhookConfig seems slightly odd since the namespace wasn't the resource that was responsible for creating it. On the other hand it's a sure fire way to clean up any vestigial resources as we know for a fact that fleet-system will definitely get deleted when helm chart is uninstalled. I guess it comes down to convention on whether this approach is valid |
Verification
|


Description of your changes
Updated the validating webhook configuration to have an owner reference to the fleet-system namespace.
Fixes #345
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
TBA