-
Notifications
You must be signed in to change notification settings - Fork 38
feat: support CA bundle and identity cert/key authentication #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support CA bundle and identity cert/key authentication #361
Conversation
* Change the helm adjust the new arguments and environment variable inputs
|
@microsoft-github-policy-service agree [company="LinkedIn"] |
|
@microsoft-github-policy-service agree company="LinkedIn" |
* change useCaAuth to useCAAuth * Edit the error msg for the token missing to reflect the CA auth logic
michaelawyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
zhiying-lin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment, others LGTM
Can you change the PR title to "feat: support CA bundle and identity cert/key authentication"? i remember we have the pr title lint check and not sure why the current one did not fail.
Thank you so much!
That is odd, I triggered it manually. |
…cision list output (#361)
Description of your changes
Provide an solution for community to support CA auth
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested