feat: a new "scope" argument for refresh-token #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingqishao
changed the title
mingqishao
changed the title
mingqishao
changed the title
cmd/authtoken/main.go
Outdated
Comment on lines
26
to
29
| const ( | ||
| aksAADApplicationID = "6dae42f8-4368-4678-94ff-3960e28e3630" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
why move the azure specific const to the main?
Contributor
Author
There was a problem hiding this comment.
I have moved back the const to pkg/authtoken/providers/azure/azure_msi.go, and keep the default scope value logic there too.
ryanzhang-oss
requested changes
May 12, 2023
Contributor
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
The new scope field is not even assigned.
…ify the type 2. move the default scope logic to pkg/authtoken/providers/azure/azure_msi.go
Contributor
Author
I found that too. That is shame. I have fixed it. |
mingqishao
changed the title
mingqishao
changed the title
ryanzhang-oss
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Today the Azure provider are using a static scope in token. In future the different scope need to be used for the flexible scenario.
This changes are:
--scopearguments in refresh-token. The new scope argument will be pass to Azure token provider.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I added unit test for changes codes
Special notes for your reviewer