feat: allow member agent use OS's root certificate authority (follow up) #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…lternative system environment
ryanzhang-oss
requested changes
May 24, 2023
| caBundle, ok := os.LookupEnv("CA_BUNDLE") | ||
| if ok && caBundle == "" { | ||
| err := errors.New("environment variable CA_BUNDLE should not be empty") | ||
| klog.ErrorS(err, "failed to validate system variables") |
Contributor
There was a problem hiding this comment.
Why not return the err here? I am not sure why we just log this as user can't see the error log. I don't think an empty env is valid. I assume that not setting it means using os default but setting it as "" ambiguous.
Contributor
Author
There was a problem hiding this comment.
I think that is a copy/paste bug. I fixed that and added unit test in this commit.
cmd/memberagent/main.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| hubConfig.TLSClientConfig.CAFile = caBundle |
Contributor
There was a problem hiding this comment.
we should only set caBundle or caData
ryanzhang-oss
approved these changes
May 30, 2023
weng271190436
pushed a commit
to weng271190436/fleet
that referenced
this pull request
Dec 8, 2025
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com> Co-authored-by: Ryan Zhang <yangzhangrice@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This is following up some comments on another PR: #364 after PR merged.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer