feat: scheduler (5/): add parallelizer #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // ErrorFlag is a flag for indicating whether an error has occurred when running tasks in | ||
| // parallel with the parallelizer. | ||
| type ErrorFlag struct { |
Contributor
There was a problem hiding this comment.
how does this work with Parallelizer?
Contributor
Author
There was a problem hiding this comment.
Hi Ryan! The error flag is designed to be used in doWork when calling parallelizer.ParallelizeUntil -> it allows exit on first error (in combination with context cancel()).
ryanzhang-oss
previously approved these changes
Jun 9, 2023
zhiying-lin
reviewed
Jun 12, 2023
zhiying-lin
previously approved these changes
Jun 12, 2023
Contributor
zhiying-lin
left a comment
zhiying-lin
left a comment
There was a problem hiding this comment.
one minor comment, others LGTM
michaelawyu
dismissed stale reviews from zhiying-lin and ryanzhang-oss
via
dd9418a
michaelawyu
force-pushed
the
scheduler-framework-parallelizer
branch
from
423dca5 to
dd9418a
Compare
zhiying-lin
approved these changes
Jun 12, 2023
weng271190436
added a commit
that referenced
this pull request
Jan 6, 2026
* decouple informer cache population and event handling Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR is part of the PRs that implement the Fleet workload scheduling.
It features a parallelizer, which the scheduler frameworks uses to run tasks in parallel.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer