Skip to content

Conversation

@zhiying-lin
Copy link
Contributor

Description of your changes

Update the v1 APIs/mainfests/generated golang code.

  • remove the rollout strategy for now, which will be a separate API. The default behavior of CRP is onDelete.
  • rename "SnapShot" to "Snapshot"

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

existing tests

michaelawyu
michaelawyu previously approved these changes Jun 12, 2023
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhiying-lin zhiying-lin merged commit 02abff4 into Azure:main Jun 12, 2023
@zhiying-lin zhiying-lin deleted the api-change branch June 12, 2023 09:06
@britaniar britaniar mentioned this pull request Jan 12, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants