fix: rename api group version #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
changed the title
michaelawyu
previously approved these changes
Jun 13, 2023
Contributor
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
I have some reservations regarding the core path, but other than that I've got no issues.
Contributor
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
There was a problem hiding this comment.
I wonder why it's moved to /apis/core? Normally the directory structure maches the group name.
ryanzhang-oss
approved these changes
Jun 15, 2023
weng271190436
pushed a commit
that referenced
this pull request
Jan 6, 2026
fix update run name CEL Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Rename API group version to placement.karavel.io/v1beta1
I have:
make reviewableto ensure this PR is ready for review.