-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Add fleet resource label to fleet namespace #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7116b73 to
2216f6c
Compare
|
Misunderstood the NamespaceSelector in ValidatingWebhook Object it selects the object that our webhook should handle based on the object's namespace and labels on the namespace, so no need to add labels on Role and Rolebindings we create |
226630e to
2c03a78
Compare
|
How do we select Role and RoleBindings then?
|
|
I just realized that we have new version of API but the webhooks only works for v1alpha1. How should we handle that? |
Since we add the label on the namespace, we can specify the validating webhook such that it only handle roles and rolebindings within the namespace with the label we added |
We can do something like this #397 |
pkg/controllers/membercluster/membercluster_controller_integration_test.go
Outdated
Show resolved
Hide resolved
00ddb79 to
e3fb167
Compare
40be576 to
cbdec5b
Compare
michaelawyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the nit everything looks great ✨
24e052f to
18bc220
Compare
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer