fix: fix crp controller & its unit tests #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, but there's another PR that's already covering the fixes I think? |
michaelawyu
approved these changes
Jun 30, 2023
Contributor
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
LGTM, PTAL at the comment.
Contributor
Author
|
i'm aware of Ryan's fix. And the UT failed there and needs to be fixed. The PR is to quickly fix the main branch and unblock us. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
fix the master broken
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
UT