feat: enforce revisionHistoryLimit for scheduling policy snapshots #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A little bit running out of time today; will review it tomorrow. Apologies. |
zhiying-lin
force-pushed
the
snapshot-cleanup
branch
from
109213c to
ba01fa0
Compare
michaelawyu
reviewed
Jul 5, 2023
michaelawyu
reviewed
Jul 5, 2023
michaelawyu
reviewed
Jul 5, 2023
michaelawyu
reviewed
Jul 5, 2023
michaelawyu
reviewed
Jul 5, 2023
michaelawyu
reviewed
Jul 6, 2023
michaelawyu
approved these changes
Jul 6, 2023
Contributor
michaelawyu
left a comment
michaelawyu
left a comment
There was a problem hiding this comment.
A nit comment, others LGTM.
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Jan 21, 2026
Added some logs Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
respect the revisionHistoryLimit field before creating a new policy snapshot.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Added unit tests
Special notes for your reviewer