runc: fix how version is set after upstream change#196
Merged
Conversation
Upstream changed how the binary version can be set which broke how we were setting it. Now we can pass a VERSION env var into runcs make file to have it use that instead of modifying the VERSION file in the repo. Because we already have a VERSION field set in the env, the runc makefile is taking that, but it does not contain the revision number, so we need to modify that env. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
pmengelbert
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream changed how the binary version can be set which broke how we were setting it.
Now we can pass a VERSION env var into runcs make file to have it use that instead of modifying the VERSION file in the repo.
Because we already have a VERSION field set in the env, the runc makefile is taking that, but it does not contain the revision number, so we need to modify that env.
Upstream change that broke this is opencontainers/runc#4270