Skip to content

Update undici 6.23.0 → 6.24.1 to fix CVE-2026-2229#458

Open
Copilot wants to merge 4 commits intomainfrom
copilot/fix-undici-websocket-client-vulnerability
Open

Update undici 6.23.0 → 6.24.1 to fix CVE-2026-2229#458
Copilot wants to merge 4 commits intomainfrom
copilot/fix-undici-websocket-client-vulnerability

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

Resolves high-severity DoS vulnerability in undici's WebSocket client where a malicious server can crash the Node.js process via invalid server_max_window_bits in the permessage-deflate extension (GHSA-v9p9-hfj2-hcw8).

  • Updated transitive dependency undici from 6.23.0 to 6.24.1 via npm update undici
  • Rebuilt dist/ bundle

Reachability Assessment

Not reachable — high confidence. The vulnerability is in undici's WebSocket client. This action only uses undici transitively through @actions/core and @actions/http-client for HTTP requests; no WebSocket APIs are used. Update is to clear the advisory.

Note on CI

The check-dist and build-test pipelines have a pre-existing failure from PR #443 (eslint v10 vs eslint-plugin-github@6.0.0 peer dependency conflict) that is unrelated to this change.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>Undici has Unhandled Exception in WebSocket Client Due to Invalid server_max_window_bits Validation</alert_title>
<alert_description>### Impact

The undici WebSocket client is vulnerable to a denial-of-service attack due to improper validation of the server_max_window_bits parameter in the permessage-deflate extension. When a WebSocket client connects to a server, it automatically advertises support for permessage-deflate compression. A malicious server can respond with an out-of-range server_max_window_bits value (outside zlib's valid range of 8-15). When the server subsequently sends a compressed frame, the client attempts to create a zlib InflateRaw instance with the invalid windowBits value, causing a synchronous RangeError exception that is not caught, resulting in immediate process termination.

The vulnerability exists because:

  1. The isValidClientWindowBits() function only validates that the value contains ASCII digits, not that it falls within the valid range 8-15
  2. The createInflateRaw() call is not wrapped in a try-catch block
  3. The resulting exception propagates up through the call stack and crashes the Node.js process

Patches

Has the problem been patched? What versions should users upgrade to?

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?</alert_description>

high
GHSA-v9p9-hfj2-hcw8, CVE-2026-2229
undici
npm
<vulnerable_versions>6.23.0</vulnerable_versions>
<patched_version>6.24.0</patched_version>
<manifest_path>package-lock.json</manifest_path>

https://github.com/nodejs/undici/security/advisories/GHSA-v9p9-hfj2-hcw8 https://nvd.nist.gov/vuln/detail/CVE-2026-2229 https://hackerone.com/reports/3487486 https://cna.openjsf.org/security-advisories.html https://datatracker.ietf.org/doc/html/rfc7692 https://nodejs.org/api/zlib.html#class-zlibinflateraw https://github.com/advisories/GHSA-v9p9-hfj2-hcw8

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attemp...

Copilot AI changed the title [WIP] Fix Undici WebSocket client vulnerability due to invalid validation Update undici 6.23.0 → 6.24.1 to fix CVE-2026-2229 Apr 9, 2026
Copilot AI requested a review from hemarina April 9, 2026 21:35
@hemarina hemarina marked this pull request as ready for review April 9, 2026 21:47
@hemarina
Copy link
Copy Markdown
Contributor

hemarina commented Apr 9, 2026

@copilot Fix failed pipeline for check dist and build-test

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 9, 2026

@copilot Fix failed pipeline for check dist and build-test

Fixed in f19e81f. The CI failure was caused by a pre-existing peer dependency conflict from PR #443 (eslint v10 vs eslint-plugin-github@6.0.0 which requires eslint@"^8 || ^9"). Added .npmrc with legacy-peer-deps=true so that npm ci and npm install succeed. Verified locally that npm ci, npm run all (build + format + lint + package), and the check-dist comparison all pass.

.npmrc Outdated
@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Remove this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 2df799a. Note that the check-dist and build-test CI failures are pre-existing from PR #443 (eslint v10 vs eslint-plugin-github@6.0.0 peer dep conflict) and unrelated to this undici update.

Agent-Logs-Url: https://github.com/Azure/setup-azd/sessions/c152597d-e08d-4d81-ad70-5f2b9c993c70

Co-authored-by: hemarina <104857065+hemarina@users.noreply.github.com>
Copilot AI requested a review from hemarina April 9, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants