Complete removal of webview-ui-toolkit package & elements #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejhan
requested review from
ReinierCC,
Tatsinnit,
bosesuneha,
davidgamero and
qpetraroia
ReinierCC
approved these changes
Apr 2, 2025
Collaborator
ReinierCC
left a comment
ReinierCC
left a comment
There was a problem hiding this comment.
Looks good! Video was a nice addition to clearly show the changes.
Also, thanks for making the needed changes to the cluster upgrade panel!
Tatsinnit
approved these changes
Apr 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes the removal of the webview-ui-toolkit package and all remaining usages from the repo.
<VSCodePanels>,<VSCodePanelTab>,<VSCodePanelView>,<VSCodeDropdownButton>, and<VSCodeProgressRing>elements<ProgressRing>element added(An addition to the documentation briefly describing our new options for custom element & future development will be posted in a PR shortly after this).
(I've decided to include a couple clips below to reduce testing & demonstrate functionality- mainly showing the page that was changed the most in this PR which is the InspektorGadget panel. Several other files were changed but in this PR they are mostly non-interactable elements, so there shouldn't be much worry of broken functionality.)
Of course still here is the .vsix and any additional testing would be appreciated!
vscode-aks-tools-1.6.2-deprecationtest.vsix.zip
Inspektor Gadget Before Changes:
gadgetbefore.mp4
After Changes:
gadgetafter.mp4
Progress Ring:
progressring.mp4
These clips are just to demonstrate that the visual/functionality is almost identical as intended.