Refine error messages of PersistenceEncryptionError and PersistenceDecryptionError#113
Merged
rayluo merged 1 commit intoAzureAD:devfrom Apr 26, 2022
Merged
Refine error messages of PersistenceEncryptionError and PersistenceDecryptionError#113rayluo merged 1 commit intoAzureAD:devfrom
PersistenceEncryptionError and PersistenceDecryptionError#113rayluo merged 1 commit intoAzureAD:devfrom
Conversation
jiasli
commented
Apr 20, 2022
| @@ -46,7 +46,7 @@ def raw(self): | |||
| "The computer must be trusted for delegation and " | |||
| "the current user account must be configured to allow delegation. " | |||
| "See also https://docs.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/enable-computer-and-user-accounts-to-be-trusted-for-delegation", | |||
Contributor
Author
There was a problem hiding this comment.
I am hesitating on whether to add a period after the link. 🤔
jiasli
commented
Apr 20, 2022
| _LOCAL_FREE(result.pbData) | ||
| err_code = _GET_LAST_ERROR() | ||
| raise OSError(None, _err_description.get(err_code), None, err_code) | ||
| raise OSError(None, _err_description.get(err_code, ''), None, err_code) |
Contributor
Author
There was a problem hiding this comment.
We should use an empty string '' as the default value. Otherwise, it becomes:
Decryption failed: [WinError 0] None App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError: 'C:\\Users\\xxx\\.azure\\msal_token_cache.bin'
but even this will result in duplicated spaces:
Decryption failed: [WinError 0] App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError
jiasli
changed the title
PersistenceEncryptionError and PersistenceDecryptionError
rayluo
approved these changes
Apr 26, 2022
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks for the real-world observation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since period is already in
microsoft-authentication-extensions-for-python/msal_extensions/windows.py
Line 44 in e30080b
The error message becomes