Removing FileTokenCache.add overload.#27
Merged
marstr merged 1 commit intoAzureAD:devfrom Jul 16, 2019
Merged
Conversation
Contributor
Author
|
Pro: Tests-pass I'm not sure how much of a con that really is, as at the end of the day the only trouble would be with cache merging semantics. I'm open to your interpretation of that! |
rayluo
approved these changes
Jul 16, 2019
Contributor
There was a problem hiding this comment.
Thanks for identifying such a tricky issue! This quick fix looks reasonable, so I'm giving an approval right now, to allow a quick subsequent release if needed.
More thoughts:
- Upstream repo does not have the same issue, because a re-entrant in-memory lock was used. In hindsight, this Extensions repo can potentially use a re-entrant lock provided by
portalockeritself, but that seems like an undocumented feature, though. - We would definitely want to have a unit test case coverage on this, in near future, if not immediately in this PR. Currently the test cases in this repo are mostly skipped by default, due to the lack of testing accounts in existing CI. We should still be able to have some unit tests which does not rely on a real test account. Something like this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26