Add IBroker implementation for MSALRuntime by Avery-Dunn · Pull Request #563 · AzureAD/microsoft-authentication-library-for-java

Avery-Dunn · 2022-10-23T23:46:18Z

Draft PR for the work-in-progress MSALRuntime integration. This PR covers

The IBroker interface, which defines a set of acquireToken methods that are to be implemented in the msal4jbrokers package
An implementation of IBroker that uses the javamsalruntime package (related PR here: https://github.com/AzureAD/microsoft-authentication-library-for-cpp/pull/3091)
Changes to MSAL Java's acquireToken flows to allow use of an IBroker implementation (in next commit)
Exception handling to covert errors from an IBroker implementation into MSAL Java-style exceptions and error messages (in next commit)

…b.com/AzureAD/microsoft-authentication-library-for-java into avdunn/msalruntime-broker

msal4j-brokers/pom.xml

msal4j-brokers/src/main/java/com/microsoft/aad/msal4jbrokers/MsalRuntimeBroker.java

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IBroker.java

msal4j-brokers/src/main/java/com/microsoft/aad/msal4jbrokers/MsalRuntimeBroker.java

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/PublicClientApplication.java

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/IBroker.java

msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AuthenticationErrorCode.java

msal4j-brokers/src/main/java/com/microsoft/aad/msal4jbrokers/MsalRuntimeBroker.java

…tion-library-for-java into avdunn/msalruntime-broker

This reverts commit aacb439.

* Add README * plugins for GPG signing * more plugins to fix failing tests * add azure-pipelines to build * Add a source file * change class modifier for javadocs * Removing developer tag * library version update to fix security vulnerability * Updated jackson-databind version * Updated versions for hotfix release. * expose instanceDiscovery flag * updated comments * updated b2c authority url for tests * address PR comments + more tests * missed update for regional endpoint * separated b2c and adfs tests * Revert unintentional commit * Revert unintentional commit * Fix Issue 572 * Fixed failing test * update regional endpoints * Updating release numbers for beta release * update versions for release * remove unintentional commit * Add IBroker implementation for MSALRuntime (#563) * Add IBroker implementation for MSALRuntime * Remove dll used during testing * Integrate broker steps to relevant flows in PublicClientApplication * Add logic to cancel MsalRuntimeFutures * Expand javadocs and exception handling * Address code review comments * Simplify future chaining, address code review comments * Reorganize future chaining, fix testing issues * Adjust how broker availability is checked * Create automated test * Adjust startup logic * Correct version number for interop * Correct broker versioning * Move broker tests to MSAL Java package * Remove usage of msal4j-brokers from msal4j * Add missing SLFJ dependency * Use newest msal4j * Bump javamsalruntime version number * Revert "Add IBroker implementation for MSALRuntime (#563)" (#588) This reverts commit aacb439. * regional endpoint change to always use login.microsoft.com * Add support for both current and legacy B2C authority formats (#594) * Add support for both current and legacy B2C authority formats * Fix B2C format test * add 2 seconds timeout while calling IMDS * Fix failing tests * Fix failing tests * delete commented out code * Use the dedicated admin consent endpoint instead of a query parameter (#599) * updated versions for release * update condition to throw exception * added test for invalid authority * Add tests for a CIAM user and reduce test code duplication (#603) * Add tests for a CIAM user and reduce code duplication in several test files * Revert changed method name * Attempt to resolve credscan flag * Resolve credscan issues * Address code review comments * Use default scope * expose extraQueryParameters * expose extraQueryParameters * ExtraQueryParameters tests * retrigger the tests * Updated an existing test case to check added parameters * Replace exception with warning * version updates for release * update json-smart version * Updated json-smart version Updated json-smart version to a 'bug-free' version * version updates for release * Initial commit * add CIAM authority file * revert authority validation changes * Fix failing tests * Fix failing tests * remove commented out line * remove unnecessary code * update exception message for device code flow * add refresh_in logic * resolve build issues + address PR comments * update tests * updated org-json version to resolve Dependabot alert * Better redirect URI error handling and dependency upgrade (#633) * Better error handling for redirect URIs * Update oauth2-oidc-sdk dependency * Address review comments Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> --------- Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> * Version updates for 1.13.8 release (#634) * Version updates for 1.13.8 release * Update changelog.txt * Point to MSAL Java reference docs onboarded to Microsoft Learn * Get main branch in sync with dev branch * Manually resolve differences between main and dev branches * Manually resolve differences between main and dev branches --------- Co-authored-by: siddhijain <siddhijain@microsoft.com> Co-authored-by: Bogdan Gavril <bogavril@microsoft.com> Co-authored-by: Dickson Mwendia <64727760+Dickson-Mwendia@users.noreply.github.com>

Add IBroker implementation for MSALRuntime

e9a44d5

Avery-Dunn mentioned this pull request Oct 23, 2022

MSALRuntime integration #530

Closed

Avery-Dunn added 3 commits December 15, 2022 15:07

Merge branches 'avdunn/msalruntime-broker' and 'dev' of https://githu…

31aa38d

…b.com/AzureAD/microsoft-authentication-library-for-java into avdunn/msalruntime-broker

Remove dll used during testing

8a8df73

Integrate broker steps to relevant flows in PublicClientApplication

5b8e235

Avery-Dunn requested a review from siddhijain December 20, 2022 17:10