Instance discovery throws exception only with invalid authority#606
Merged
siddhijain merged 2 commits intodevfrom Mar 13, 2023
Merged
Instance discovery throws exception only with invalid authority#606siddhijain merged 2 commits intodevfrom
siddhijain merged 2 commits intodevfrom
Conversation
Avery-Dunn
approved these changes
Mar 13, 2023
bgavrilMS
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a call to instance discovery fails, MSAL throws an exception in all the cases.
This PR adds 2 things -
If instance discovery fails with an error except "invalid_instance", MSAL ignores it
Once instance discovery fails, MSAL should not re-attempt to perform instance discovery on that environment