Merged
Conversation
bgavrilMS
reviewed
Apr 12, 2023
| @@ -62,11 +65,29 @@ public void acquireTokenClientCredentials_ClientAssertion() throws Exception { | |||
|
|
|||
| @Test | |||
| public void acquireTokenClientCredentials_ClientSecret_Ciam() throws Exception { | |||
bgavrilMS
reviewed
Apr 12, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/Authority.java
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Apr 12, 2023
bgavrilMS
approved these changes
Apr 12, 2023
Member
bgavrilMS
left a comment
bgavrilMS
left a comment
There was a problem hiding this comment.
LGTM, great E2E tests, I have 1 question about authority detection.
Avery-Dunn
reviewed
Apr 13, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/CIAMAuthority.java
Outdated
Show resolved
Hide resolved
Avery-Dunn
approved these changes
Apr 13, 2023
rayluo
reviewed
Apr 13, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/PublicClientApplication.java
Outdated
Show resolved
Hide resolved
rayluo
reviewed
Apr 13, 2023
msal4j-sdk/src/integrationtest/java/com.microsoft.aad.msal4j/AcquireTokenInteractiveIT.java
Show resolved
Hide resolved
rayluo
approved these changes
Apr 13, 2023
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Left a couple minor comments. They are optional. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes care of supporting a new authority type CIAM as per this Epic https://identitydivision.visualstudio.com/Engineering/_workitems/edit/2473109