Issue 447 - support for macOs, Linux and Unix #651
Merged
siddhijain merged 3 commits intodevfrom May 16, 2023
Merged
Conversation
bgavrilMS
reviewed
May 11, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AcquireTokenByInteractiveFlowSupplier.java
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
May 11, 2023
| String os = System.getProperty("os.name").toLowerCase(); | ||
| if (os.contains("windows")) { | ||
| openDefaultSystemBrowserInWindows(url); | ||
| } else if (os.contains("mac")) { // mac os |
bgavrilMS
reviewed
May 11, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/AcquireTokenByInteractiveFlowSupplier.java
Outdated
Show resolved
Hide resolved
Avery-Dunn
reviewed
May 15, 2023
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/OSHelper.java
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
May 15, 2023
Avery-Dunn
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix allows opening a default browser depending on the operating system. In the absence of a Mac device, we do not have a way to test it.
#447