-
Notifications
You must be signed in to change notification settings - Fork 155
Broker fixes and feedback #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Avery-Dunn
merged 29 commits into
avdunn/msalruntime-broker
from
avdunn/fixes-and-feedback
Oct 20, 2023
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9ca518c
Delete codeql.yml
bgavrilMS 24c6d2a
Merge pull request #670 from AzureAD/bgavrilMS-patch-2
bgavrilMS 3c00622
Test framework update (#672)
Avery-Dunn 2976239
Update CIAM tests (#673)
Avery-Dunn 0efcce1
Bump guava from 31.1-jre to 32.0.0-jre in /msal4j-sdk (#671)
bgavrilMS 6dc951b
Delete contributing.md (#667)
bgavrilMS 3d1ca7c
Create Contributing.md (#668)
bgavrilMS 8bf42f2
Version changes for 1.13.9 (#674)
Avery-Dunn 1dfb59c
Add space between command and arguments when executing linux command …
ricemery efee88f
Assorted fixes (#684)
Avery-Dunn feabcde
Issue-679: Fix for Account Cache; .contains() was not possible and yo…
gterminator ef40ea0
Version changes for 1.13.10 (#685)
Avery-Dunn 4dc7a5e
Move changelog
bgavrilMS 2556448
Move changelog to root
bgavrilMS 1987f77
Merge pull request #686 from AzureAD/bogavril/ch
bgavrilMS ddc953f
Update issue templates (#707)
bgavrilMS afc8a15
Re-add lombok source line (#705)
Avery-Dunn f31cd8b
Version changes for release 1.13.11 (#714)
Avery-Dunn 746631e
Update bug report
bgavrilMS 6813286
Delete .github/ISSUE_TEMPLATE/bug_report.md
bgavrilMS d7e085d
Merge pull request #718 from AzureAD/bgavrilMS-patch-3
bgavrilMS 041bd01
Update bug_report.yaml
bgavrilMS 09c8222
Create FeatureRequest.yaml
bgavrilMS ff34ddd
Merge pull request #719 from AzureAD/bgavrilMS-patch-4
bgavrilMS 2edc49b
Update FeatureRequest.yaml
bgavrilMS 39eb7d8
Set default throttling time to 5 sec (#721)
akulyakhtin 6fc2c6c
Ensure correlation ID is never null
Avery-Dunn 1ddc76b
Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…
Avery-Dunn b315b3e
Rename MsalRuntimeBroker and add builder pattern for better API consi…
Avery-Dunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: Feature request | ||
| description: Suggest a new feature for MSAL Java | ||
| labels: ["feature request", "untriaged", "needs attention"] | ||
| title : '[Feature Request] ' | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| ## Before submitting your feature request | ||
| Please make sure that your question or issue is not already covered in [MSAL documentation](https://learn.microsoft.com/entra/msal/java/) or [samples](https://learn.microsoft.com/azure/active-directory/develop/sample-v2-code?tabs=apptype). | ||
|
|
||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| ## Feature request for MSAL Java | ||
|
|
||
| - type: dropdown | ||
| attributes: | ||
| label: MSAL client type | ||
| description: Are you using PublicClientApplication (desktop / CLI apps), ConfidentialClientApplication (web apps, web APIs, service-to-service) or ManagedIdentityApplication? | ||
| multiple: true | ||
| options: | ||
| - "Public" | ||
| - "Confidential" | ||
| - "Managed identity" | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Problem Statement | ||
| description: "Describe the problem or context for this feature request." | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Proposed solution | ||
| description: "Describe the solution you'd like." | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Alternatives | ||
| description: "Describe alternatives you've considered." | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| name: Bug report | ||
| description: Broken or unintended behavior with MSAL4J library | ||
| title: '[Bug] ' | ||
| labels: ["untriaged", "needs attention"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| ## Before submitting your issue | ||
| Please make sure that your question or issue is not already covered in existing issues | ||
|
|
||
| **Logs and network traces** | ||
| Without logs or traces, it is unlikely that the team can investigate your issue. Capturing logs is described in our [Docs](https://learn.microsoft.com/azure/active-directory/develop/msal-logging-java). | ||
|
|
||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| ## Issue details | ||
|
|
||
| - type: input | ||
| attributes: | ||
| label: Library version used | ||
| description: "Enter the version of the library where you ran into the issue (e.g. 1.13.10)." | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| attributes: | ||
| label: Java version | ||
| description: "Enter the Java SDK and Framework version your application is developed in." | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: dropdown | ||
| attributes: | ||
| label: Scenario | ||
| description: "Are you using PublicClientApplication, ConfidentialClientApplication or ManagedIdentityApplication?" | ||
| multiple: true | ||
| options: | ||
| - "PublicClient (AcquireTokenInteractive, AcquireTokenByUsernamePassword)" | ||
| - "ConfidentialClient - web site (AcquireTokenByAuthCode)" | ||
| - "ConfidentialClient - web api (AcquireTokenOnBehalfOf)" | ||
| - "ConfidentialClient - service to service (AcquireTokenForClient)" | ||
| - "ManagedIdentityClient - managed identity" | ||
| - "Other - please specify" | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: dropdown | ||
| attributes: | ||
| label: Is this a new or an existing app? | ||
| description: "Is this a new or existing app?" | ||
| multiple: false | ||
| options: | ||
| - "The app is in production, and I have upgraded to a new version of MSAL" | ||
| - "The app is in production, I haven't upgraded MSAL, but started seeing this issue" | ||
| - "This is a new app or experiment" | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Issue description and reproduction steps | ||
| description: "Briefly explain the issue you are seeing along with any error messages or stack trace. Provide a link to one of the [standard samples](https://learn.microsoft.com/azure/active-directory/develop/sample-v2-code?tabs=apptype) and steps to reproduce the behavior. Make sure to provide verbose level log messages from MSAL, if available. [Learn more](https://learn.microsoft.com/azure/active-directory/develop/msal-logging-dotnet)" | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Relevant code snippets | ||
| description: "Provide relevant code snippets that can be used to reproduce the issue." | ||
| render: csharp | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Expected behavior | ||
| description: "Describe what you expect the behavior to be." | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: dropdown | ||
| attributes: | ||
| label: Identity provider | ||
| options: | ||
| - Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts) | ||
| - Azure B2C Basic Policy | ||
| - Azure B2C Custom Policy | ||
| - Azure Active Directory Federation Services (ADFS) | ||
| - Microsoft Entra External ID | ||
| - Other | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| attributes: | ||
| label: Regression | ||
| description: "If this behavior worked before, enter the last working version(s) of MSAL." | ||
| placeholder: "MSAL version: " | ||
|
|
||
| - type: textarea | ||
| attributes: | ||
| label: Solution and workarounds | ||
| description: "Possible solution or workarounds, if you know of any." | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: markdown | ||
| attributes: | ||
| value: "## Security Reporting" | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| If you find a security issue with our libraries or services [please report it to the Microsoft Security Response Center (MSRC)](https://aka.ms/report-security-issue) with as much detail as possible. Your submission may be eligible for a bounty through the [Microsoft Bounty](http://aka.ms/bugbounty) program. Please do not post security issues to GitHub Issues or any other public site. We will contact you shortly upon receiving the information. We encourage you to get notifications of when security incidents occur by visiting [this page](https://www.microsoft.com/msrc/technical-security-notifications) and subscribing to Security Advisory Alerts. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # CONTRIBUTING | ||
|
|
||
| Microsoft Authentication Library for Java welcomes new contributors. This document will guide you | ||
| through the process. | ||
|
|
||
| ## CONTRIBUTOR LICENSE AGREEMENT | ||
|
|
||
| Please visit [https://cla.microsoft.com/](https://cla.microsoft.com/) and sign the Contributor License | ||
| Agreement. You only need to do that once. We can not look at your code until you've submitted this request. | ||
|
|
||
|
|
||
| ## Build | ||
|
|
||
| Use Java8. | ||
|
|
||
| ## Test | ||
|
|
||
| Unit tests should run as expected. Integration tests require certificate / secrets which are deployed on CI. External contributors are not able to run integration tests manually. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably open a separate PR to update this file 😄 Currently it's pretty barebones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized that because I merged the latest dev into the msalruntime-broker branch it's showing a lot of unecessary file changes... This file and most of the other changes have already been committed into dev, the branch that this PR is being merged into was just quite behind.
For the API changes that you might be more interested in, see this commit: b315b3e