Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
9ca518c
Delete codeql.yml
bgavrilMS Jul 5, 2023
24c6d2a
Merge pull request #670 from AzureAD/bgavrilMS-patch-2
bgavrilMS Jul 5, 2023
3c00622
Test framework update (#672)
Avery-Dunn Jul 10, 2023
2976239
Update CIAM tests (#673)
Avery-Dunn Jul 10, 2023
0efcce1
Bump guava from 31.1-jre to 32.0.0-jre in /msal4j-sdk (#671)
bgavrilMS Jul 11, 2023
6dc951b
Delete contributing.md (#667)
bgavrilMS Jul 11, 2023
3d1ca7c
Create Contributing.md (#668)
bgavrilMS Jul 11, 2023
8bf42f2
Version changes for 1.13.9 (#674)
Avery-Dunn Jul 11, 2023
1dfb59c
Add space between command and arguments when executing linux command …
ricemery Jul 26, 2023
efee88f
Assorted fixes (#684)
Avery-Dunn Aug 3, 2023
feabcde
Issue-679: Fix for Account Cache; .contains() was not possible and yo…
gterminator Aug 6, 2023
ef40ea0
Version changes for 1.13.10 (#685)
Avery-Dunn Aug 7, 2023
4dc7a5e
Move changelog
bgavrilMS Aug 9, 2023
2556448
Move changelog to root
bgavrilMS Aug 9, 2023
1987f77
Merge pull request #686 from AzureAD/bogavril/ch
bgavrilMS Sep 7, 2023
ddc953f
Update issue templates (#707)
bgavrilMS Sep 12, 2023
afc8a15
Re-add lombok source line (#705)
Avery-Dunn Sep 21, 2023
f31cd8b
Version changes for release 1.13.11 (#714)
Avery-Dunn Sep 22, 2023
746631e
Update bug report
bgavrilMS Sep 29, 2023
6813286
Delete .github/ISSUE_TEMPLATE/bug_report.md
bgavrilMS Sep 29, 2023
d7e085d
Merge pull request #718 from AzureAD/bgavrilMS-patch-3
bgavrilMS Sep 29, 2023
041bd01
Update bug_report.yaml
bgavrilMS Sep 29, 2023
09c8222
Create FeatureRequest.yaml
bgavrilMS Sep 29, 2023
ff34ddd
Merge pull request #719 from AzureAD/bgavrilMS-patch-4
bgavrilMS Sep 29, 2023
2edc49b
Update FeatureRequest.yaml
bgavrilMS Sep 29, 2023
39eb7d8
Set default throttling time to 5 sec (#721)
akulyakhtin Oct 6, 2023
6fc2c6c
Ensure correlation ID is never null
Avery-Dunn Oct 8, 2023
1ddc76b
Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…
Avery-Dunn Oct 20, 2023
b315b3e
Rename MsalRuntimeBroker and add builder pattern for better API consi…
Avery-Dunn Oct 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .github/ISSUE_TEMPLATE/FeatureRequest.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Feature request
description: Suggest a new feature for MSAL Java
labels: ["feature request", "untriaged", "needs attention"]
title : '[Feature Request] '
body:
- type: markdown
attributes:
value: |
## Before submitting your feature request
Please make sure that your question or issue is not already covered in [MSAL documentation](https://learn.microsoft.com/entra/msal/java/) or [samples](https://learn.microsoft.com/azure/active-directory/develop/sample-v2-code?tabs=apptype).

- type: markdown
attributes:
value: |
## Feature request for MSAL Java

- type: dropdown
attributes:
label: MSAL client type
description: Are you using PublicClientApplication (desktop / CLI apps), ConfidentialClientApplication (web apps, web APIs, service-to-service) or ManagedIdentityApplication?
multiple: true
options:
- "Public"
- "Confidential"
- "Managed identity"
validations:
required: true

- type: textarea
attributes:
label: Problem Statement
description: "Describe the problem or context for this feature request."
validations:
required: true

- type: textarea
attributes:
label: Proposed solution
description: "Describe the solution you'd like."
validations:
required: false

- type: textarea
attributes:
label: Alternatives
description: "Describe alternatives you've considered."
validations:
required: false
115 changes: 115 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
name: Bug report
description: Broken or unintended behavior with MSAL4J library
title: '[Bug] '
labels: ["untriaged", "needs attention"]
body:
- type: markdown
attributes:
value: |
## Before submitting your issue
Please make sure that your question or issue is not already covered in existing issues

**Logs and network traces**
Without logs or traces, it is unlikely that the team can investigate your issue. Capturing logs is described in our [Docs](https://learn.microsoft.com/azure/active-directory/develop/msal-logging-java).

- type: markdown
attributes:
value: |
## Issue details

- type: input
attributes:
label: Library version used
description: "Enter the version of the library where you ran into the issue (e.g. 1.13.10)."
validations:
required: true

- type: input
attributes:
label: Java version
description: "Enter the Java SDK and Framework version your application is developed in."
validations:
required: true

- type: dropdown
attributes:
label: Scenario
description: "Are you using PublicClientApplication, ConfidentialClientApplication or ManagedIdentityApplication?"
multiple: true
options:
- "PublicClient (AcquireTokenInteractive, AcquireTokenByUsernamePassword)"
- "ConfidentialClient - web site (AcquireTokenByAuthCode)"
- "ConfidentialClient - web api (AcquireTokenOnBehalfOf)"
- "ConfidentialClient - service to service (AcquireTokenForClient)"
- "ManagedIdentityClient - managed identity"
- "Other - please specify"
validations:
required: true

- type: dropdown
attributes:
label: Is this a new or an existing app?
description: "Is this a new or existing app?"
multiple: false
options:
- "The app is in production, and I have upgraded to a new version of MSAL"
- "The app is in production, I haven't upgraded MSAL, but started seeing this issue"
- "This is a new app or experiment"
validations:
required: false

- type: textarea
attributes:
label: Issue description and reproduction steps
description: "Briefly explain the issue you are seeing along with any error messages or stack trace. Provide a link to one of the [standard samples](https://learn.microsoft.com/azure/active-directory/develop/sample-v2-code?tabs=apptype) and steps to reproduce the behavior. Make sure to provide verbose level log messages from MSAL, if available. [Learn more](https://learn.microsoft.com/azure/active-directory/develop/msal-logging-dotnet)"
validations:
required: true

- type: textarea
attributes:
label: Relevant code snippets
description: "Provide relevant code snippets that can be used to reproduce the issue."
render: csharp
validations:
required: false

- type: textarea
attributes:
label: Expected behavior
description: "Describe what you expect the behavior to be."
validations:
required: false

- type: dropdown
attributes:
label: Identity provider
options:
- Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)
- Azure B2C Basic Policy
- Azure B2C Custom Policy
- Azure Active Directory Federation Services (ADFS)
- Microsoft Entra External ID
- Other
validations:
required: true

- type: input
attributes:
label: Regression
description: "If this behavior worked before, enter the last working version(s) of MSAL."
placeholder: "MSAL version: "

- type: textarea
attributes:
label: Solution and workarounds
description: "Possible solution or workarounds, if you know of any."
validations:
required: false

- type: markdown
attributes:
value: "## Security Reporting"
- type: markdown
attributes:
value: |
If you find a security issue with our libraries or services [please report it to the Microsoft Security Response Center (MSRC)](https://aka.ms/report-security-issue) with as much detail as possible. Your submission may be eligible for a bounty through the [Microsoft Bounty](http://aka.ms/bugbounty) program. Please do not post security issues to GitHub Issues or any other public site. We will contact you shortly upon receiving the information. We encourage you to get notifications of when security incidents occur by visiting [this page](https://www.microsoft.com/msrc/technical-security-notifications) and subscribing to Security Advisory Alerts.
46 changes: 0 additions & 46 deletions .github/workflows/codeql.yml

This file was deleted.

18 changes: 18 additions & 0 deletions Contributing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# CONTRIBUTING

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably open a separate PR to update this file 😄 Currently it's pretty barebones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that because I merged the latest dev into the msalruntime-broker branch it's showing a lot of unecessary file changes... This file and most of the other changes have already been committed into dev, the branch that this PR is being merged into was just quite behind.

For the API changes that you might be more interested in, see this commit: b315b3e


Microsoft Authentication Library for Java welcomes new contributors. This document will guide you
through the process.

## CONTRIBUTOR LICENSE AGREEMENT

Please visit [https://cla.microsoft.com/](https://cla.microsoft.com/) and sign the Contributor License
Agreement. You only need to do that once. We can not look at your code until you've submitted this request.


## Build

Use Java8.

## Test

Unit tests should run as expected. Integration tests require certificate / secrets which are deployed on CI. External contributors are not able to run integration tests manually.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Quick links:
The library supports the following Java environments:
- Java 8 (or higher)

Current version - 1.13.8
Current version - 1.13.11

You can find the changes for each version in the [change log](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/main/msal4j-sdk/changelog.txt).

Expand All @@ -28,13 +28,13 @@ Find [the latest package in the Maven repository](https://mvnrepository.com/arti
<dependency>
<groupId>com.microsoft.azure</groupId>
<artifactId>msal4j</artifactId>
<version>1.13.8</version>
<version>1.13.11</version>
</dependency>
```
### Gradle

```gradle
implementation group: 'com.microsoft.azure', name: 'com.microsoft.aad.msal4j', version: '1.13.8'
implementation group: 'com.microsoft.azure', name: 'com.microsoft.aad.msal4j', version: '1.13.11'
```

## Usage
Expand Down
16 changes: 16 additions & 0 deletions msal4j-sdk/changelog.txt → changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,22 @@ Version 1.14.0-beta
- Add IBroker interface
- Add app-level parameter for enabling the use of auth brokers

Version 1.13.11
=============
- Hotfix for internal docs generation issue (#705)

Version 1.13.10
=============
- Remove default HTTP timeout (#664)
- Add equals/hash logic to Account class based on homeAccountID (#681)
- Fix issue with command to open default browser on Linux (#683)
- Handle null pointer exception in certain ADFS scenarios (#669)

Version 1.13.9
=============
- Update automated tests to use JUnit 5/Mockito instead of TestNG/Powermock
- Fix issue with interactive flow on macOS/Linux/Unix systems

Version 1.13.8
=============
- Added support for CIAM authority
Expand Down
Loading