Skip to content

Do not add account when performing acquire_token_silent()#262

Merged
rayluo merged 2 commits intodevfrom
dont-add-account-when-silent
Oct 16, 2020
Merged

Do not add account when performing acquire_token_silent()#262
rayluo merged 2 commits intodevfrom
dont-add-account-when-silent

Conversation

@rayluo
Copy link
Contributor

@rayluo rayluo commented Oct 13, 2020

This will fix #258

@rayluo rayluo requested a review from abhidnya13 October 13, 2020 21:49
@abhidnya13
Copy link
Contributor

Hey Ray, I went through the changes and from what I understand is we skip adding an account in the case of an acquire token silent. So the only place where an account will be added is when we acquire token by rest of the methods.

@abhidnya13 abhidnya13 self-requested a review October 16, 2020 04:47
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :shipit:

@rayluo rayluo merged commit 93c4c79 into dev Oct 16, 2020
@rayluo rayluo deleted the dont-add-account-when-silent branch October 16, 2020 18:55
@rayluo rayluo mentioned this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential loss of sign-out

2 participants