Merged
Conversation
abhidnya13
force-pushed
the
private-key-with-password
branch
3 times, most recently
from
f614596 to
50800e2
Compare
|
unit test? |
rayluo
reviewed
Oct 27, 2020
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Overall it looks good! Leave a couple minor comment below to hear your thoughts.
rayluo
suggested changes
Oct 28, 2020
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks! Per our discussion yesterday, please also add the two new dependencies into our setup.py (otherwise it would break). We can probably use the same version requirements used by Azure SDK.
After that, this would be good to go!
Contributor
Author
Contributor
Author
|
Thanks for adding the tests @rayluo ! Besides, I have also manually tested this scenario e2e using an encrypted private key and verified it works as expected. |
rayluo
force-pushed
the
private-key-with-password
branch
2 times, most recently
from
cc3b696 to
2ded277
Compare
Code refactoring Changing reference doc string Adding tests PR review 1 Adding dependencies and polishing code Python 2 compat
Adding missing arguments to api call Use cryptography lower bound as low as 0.6 Add test cases for _str2bytes() Choose cryptography upper bound as <4
rayluo
approved these changes
Oct 30, 2020
Contributor
rayluo
left a comment
rayluo
left a comment
There was a problem hiding this comment.
Thanks Abhi! We finished this together, in pair-programming style! :-D
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage: We add one more optional field
passphrasein the existingclient_credentialparameter ofConfidentialClientApplication. The docs will also be updated here